[BUGFIX][BACKPORT-0.6][ARITH] Fix FloorMod Simplifier #5505
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc @yongfeng-nv @Hzfengsy @icemelon9 |
Hzfengsy
approved these changes
May 4, 2020
tqchen
approved these changes
May 4, 2020
|
Thanks @kevinthesun I checked and it is indeed the correct fix. Thanks @junrushao1994 @Hzfengsy |
tqchen
changed the title
|
@kevinthesun can you also send a PR to the 0.6 branch? Thank you! |
Sure will do. |
trevor-m
pushed a commit
to trevor-m/tvm
that referenced
this pull request
Jun 9, 2020
trevor-m
pushed a commit
to trevor-m/tvm
that referenced
this pull request
Jun 18, 2020
trevor-m
pushed a commit
to neo-ai/tvm
that referenced
this pull request
Jun 18, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this issue, tvm StorageFlatten pass messes up indexing. The reason is that in Canonical Simplifier SplitModConst function, scale is not updated for updated SplitExpr.
@tqchen Could you take a look and make sure this is the appropriate fix?